Skip to content

Pass tag to the Github action uncomponent upload action #7271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2022

Conversation

kumekay
Copy link
Contributor

@kumekay kumekay commented Sep 19, 2022

Description of Change

By default actions/checkout@v2 makes a shallow clone and doesn't fetch tags. There are 2 ways to overcome it:

  • Fetch tags
  • Use github.ref_name which will contain tag value if the workflow is started for a tag.

This PR uses the latter option. It also updates the action repo for proper action versioning.

@me-no-dev me-no-dev merged commit f4bd568 into espressif:master Sep 19, 2022
JNewtron pushed a commit to JNewtron/arduino-esp32 that referenced this pull request Sep 20, 2022
JNewtron added a commit to JNewtron/arduino-esp32 that referenced this pull request Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants